Skip to content

Append trailing space to mu4e-last-query as well #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2015
Merged

Append trailing space to mu4e-last-query as well #27

merged 1 commit into from
Sep 22, 2015

Conversation

iqbalansari
Copy link
Contributor

I often start typing the search query after starting helm-mu (from mu4e header view) only to realize later that there was no space after the query picked from the header view, this change automatically adds a space to the search query irrespective of the source of initial input.

@tmalsburg
Copy link
Member

This one was bugging me for a long time but I didn't get around fixing it.

Is it really necessary to append the space only if the query string is non-empty and doesn't end with a space? My understanding is that a double space wouldn't do any harm.

@iqbalansari
Copy link
Contributor Author

You are right the extra spaces do not matter, but I kept it that way since it more 'stricter'. I not tied it tough and will remove the check if you think it is unnecesssary

tmalsburg added a commit that referenced this pull request Sep 22, 2015
Append trailing space to mu4e-last-query as well
@tmalsburg tmalsburg merged commit b0fe83e into emacs-helm:master Sep 22, 2015
@tmalsburg
Copy link
Member

Well, let's keep it. It doesn't do any harm.

@tmalsburg
Copy link
Member

Thanks for another really useful pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants