Rename music puzzle components & move to a new home

[wjt]

Currently the components live in the lorequest and have names specific to the particular music puzzle instance. Suggested renamings:

• MusicPuzzle: SequencePuzzle
• MusicalRockXylophone: deleted Remove MusicalRockXylophone #519
• MusicalRock: SequencePuzzleObject
• BonfireSign: SequenceHint / SequenceHintSign / ????
  • is_ignited: is_solved
• notes ABCDEFG: these are gone, replaced by a SequencePuzzleStep node Specify puzzle sequences without musical notes #522 that has a sequence property (list of SequencePuzzleObject) and a hint sign property

[wjt]

As for where thing should live:

• scenes/game_logic/sequence_puzzle.gd
• scenes/game_logic/sequence_puzzle_step.gd
• scenes/game_logic/props/sequence_puzzle_object/sequence_puzzle_object.tscn
  • scenes/game_logic/props/sequence_puzzle_object/components/sequence_puzzle_object.gd
• scenes/game_logic/props/sequence_puzzle_hint_sign/sequence_puzzle_hint_sign.tscn
  • scenes/game_logic/props/sequence_puzzle_hint_sign/components/sequence_puzzle_hint_sign.gd

It's kind of an awkwards split but it matches the other minigames.

[hydrolet]

this works for us!