Skip to content

Rename music puzzle components & move to a new home #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wjt opened this issue May 8, 2025 · 2 comments · Fixed by #607
Closed

Rename music puzzle components & move to a new home #526

wjt opened this issue May 8, 2025 · 2 comments · Fixed by #607
Assignees
@wjt

Comments

@wjt
Copy link
Member

wjt commented May 8, 2025 •
edited
Loading

Currently the components live in the lorequest and have names specific to the particular music puzzle instance. Suggested renamings:
@wjt
Copy link
Member Author

wjt commented May 14, 2025

As for where thing should live:

  • scenes/game_logic/sequence_puzzle.gd
  • scenes/game_logic/sequence_puzzle_step.gd
  • scenes/game_logic/props/sequence_puzzle_object/sequence_puzzle_object.tscn
    • scenes/game_logic/props/sequence_puzzle_object/components/sequence_puzzle_object.gd
  • scenes/game_logic/props/sequence_puzzle_hint_sign/sequence_puzzle_hint_sign.tscn
    • scenes/game_logic/props/sequence_puzzle_hint_sign/components/sequence_puzzle_hint_sign.gd

It's kind of an awkwards split but it matches the other minigames.

@hydrolet
Copy link
Contributor

this works for us!

@wjt wjt moved this to Todo in Threadbare MVP May 14, 2025
@wjt wjt mentioned this issue May 15, 2025
Merged
@wjt wjt self-assigned this May 15, 2025
@wjt wjt moved this from Todo to In Progress in Threadbare MVP May 15, 2025
wjt added a commit that referenced this issue May 15, 2025
@wjt
Rename BonfireSign to SequencePuzzleHintSign
cbed64b 
The "bonfire" nature of this sign is now specific to the LoreQuest music
puzzle. Rename the scene to a generic name, updating references elsewhere.

#526
wjt added a commit that referenced this issue May 15, 2025
@wjt
Move SequencePuzzleHintSign to game_elements
52526ed 
Previouly this component was buried inside the first lorequest.

Rehome it to game_elements/props, which matches comparable props like
the ink jars in the combat minigame.

#526
wjt added a commit that referenced this issue May 15, 2025
@wjt
Rename MusicalRock to SequencePuzzleObject
1a66dd9 
This is no longer necessarily a rock, nor musical, but a generic object
that can be kicked and may or may not make a musical sound when the
player does so.

Rename the scene & class; adjust its API to reflect its new generic
nature. Rehouse it from a xylophone directory in the lorequest puzzle
into the components tree. Move the rock sprite frames up one level of
the hierarchy, to the lorequest puzzle's components directory.

#526
wjt added a commit that referenced this issue May 15, 2025
@wjt
Rename MusicPuzzle to SequencePuzzle
88466b2 
This is no longer music-specific.

Rename MusicPuzzle to SequencePuzzle, and move it plus its
SequencePuzzleStep sub-component to the game_logic directory.

Fixes #526
wjt added a commit that referenced this issue May 15, 2025
@wjt
Template: Rename music_puzzle to sequence_puzzle
fc03674 
It's no longer necessarily musical. Rename the scene, nodes within it,
its directory, and relevant assets. Update the dialogue.

#526
@wjt wjt mentioned this issue May 15, 2025
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Threadbare MVP May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wjt wjt

Labels
None yet
Projects
Threadbare MVP
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename music puzzle to sequence puzzle endlessm/threadbare
2 participants
@wjt @hydrolet