rpi_init.sh, Failed to request IRQ for Handshake pin, err:-22

[savenlid]

Checklist

• Checked the issue tracker for similar issues to ensure this is not a duplicate
• Read the documentation to confirm the issue is not addressed there and your configuration is set correctly
• Tested with the latest version to ensure the issue hasn't been fixed

How often does this bug occurs?

always

Expected behavior

I want the command

bash rpi_init.sh spi

to create a wlan1 device ( since wlan0 already exists and thats how I connect to this rpi5)

Actual behavior (suspected bug)

insmod: ERROR: could not insert module esp32_spi.ko: Invalid parameters

Error logs or terminal output

I did fix the GPIO+512 numbering sceme as I failed that initially.
But this one I dont know what do do with.
He cant attach and IRQ to that pin, ok, I dont know why.


Rasberry-pi-5

pi@RPI16:~/esp/esp-hosted/esp_hosted_ng/host $ uname -r
6.12.20+rpt-rpi-2712

pi@RPI16:~/esp/esp-hosted/esp_hosted_ng/host $ ls -lrt /dev/spi*
crw-rw---- 1 root spi 153, 2 Apr  3 11:09 /dev/spidev10.0
crw-rw---- 1 root spi 153, 1 Apr  3 11:09 /dev/spidev0.1

pi@RPI16:~/esp/esp-hosted/esp_hosted_ng/host $ bash rpi_init.sh spi
Building for spi protocol
rm: cannot remove 'spidev_disabler.dtbo': No such file or directory
rm -rf *.o sdio/*.o spi/*.o *.ko
make ARCH=arm64 CROSS_COMPILE= -C /lib/modules/6.12.20+rpt-rpi-2712/build M=/home/pi/esp/esp-hosted/esp_hosted_ng/host clean
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make[1]: Entering directory '/usr/src/linux-headers-6.12.20+rpt-rpi-2712'
  CLEAN   /home/pi/esp/esp-hosted/esp_hosted_ng/host/Module.symvers
make[1]: Leaving directory '/usr/src/linux-headers-6.12.20+rpt-rpi-2712'
make ARCH=arm64 CROSS_COMPILE= -C /lib/modules/6.12.20+rpt-rpi-2712/build M=/home/pi/esp/esp-hosted/esp_hosted_ng/host modules
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make[1]: Entering directory '/usr/src/linux-headers-6.12.20+rpt-rpi-2712'
  CC [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/spi/esp_spi.o
  CC [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/esp_bt.o
  CC [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/main.o
  CC [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/esp_cmd.o
  CC [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/esp_utils.o
  CC [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/esp_cfg80211.o
  CC [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/esp_stats.o
  CC [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/esp_debugfs.o
  CC [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/esp_log.o
  LD [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/esp32_spi.o
  MODPOST /home/pi/esp/esp-hosted/esp_hosted_ng/host/Module.symvers
  CC [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/esp32_spi.mod.o
  CC [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/.module-common.o
  LD [M]  /home/pi/esp/esp-hosted/esp_hosted_ng/host/esp32_spi.ko
make[1]: Leaving directory '/usr/src/linux-headers-6.12.20+rpt-rpi-2712'
insmod: ERROR: could not insert module esp32_spi.ko: Invalid parameters



journalctl -xe

Apr 03 11:40:51 RPI16 sudo[3719]:       pi : TTY=pts/0 ; PWD=/home/pi/esp/esp-hosted/esp_hosted_ng/host ; USER=root ; COMMAND=/usr/bin/dtoverlay -d . spidev_disabler
Apr 03 11:40:51 RPI16 sudo[3719]: pam_unix(sudo:session): session opened for user root(uid=0) by pi(uid=1000)
Apr 03 11:40:51 RPI16 sudo[3719]: pam_unix(sudo:session): session closed for user root
Apr 03 11:40:51 RPI16 kernel: OF: overlay: WARNING: memory leak will occur if overlay removed, property: /axi/pcie@1000120000/rp1/spi@50000/spidev@0/status
Apr 03 11:41:00 RPI16 sudo[4071]:       pi : TTY=pts/0 ; PWD=/home/pi/esp/esp-hosted/esp_hosted_ng/host ; USER=root ; COMMAND=/usr/sbin/insmod esp32_spi.ko resetpin=518 raw_tp_mode=0 ota_file=
Apr 03 11:41:00 RPI16 sudo[4071]: pam_unix(sudo:session): session opened for user root(uid=0) by pi(uid=1000)
Apr 03 11:41:00 RPI16 kernel: esp32_spi: spi_dev_init: Using SPI MODE 2
Apr 03 11:41:00 RPI16 kernel: esp32_spi: spi_dev_init: Config - SPI GPIOs: Handshake[534] Dataready[539]
Apr 03 11:41:00 RPI16 kernel: esp32_spi: spi_dev_init: Config - SPI clock[10MHz] bus[0] cs[0] mode[2]
Apr 03 11:41:00 RPI16 kernel: esp32_spi: spi_dev_init: Failed to request IRQ for Handshake pin, err:-22
Apr 03 11:41:01 RPI16 kernel: esp32_spi: spi_init: Failed Init SPI device
Apr 03 11:41:01 RPI16 sudo[4071]: pam_unix(sudo:session): session closed for user root

Steps to reproduce the behavior

Followed the guide ( with quite many struggles )

Project release version

as it stands on github in this very moment.

System architecture

ARM 32-bit (Raspberry Pi 32-bit)

Operating system

Linux

Operating system version

raspbian

Shell

Bash

Additional context

No response

[mantriyogesh]

Hello @savenlid ,

Possibly that GPIO is in use by someone/something else. For Handshake and Data Ready, any other free GPIO could also be configured. Would you be able to try with some other GPIO?

But as I see that your request is for Raspberry Pi 5 specific. I have not yet migrated or tested on Raspberry Pi 5, I initially thought it should be very similar to Raspberry Pi 4 or 3b+. But I think it is not the case.

As I search, I get to see that

The GPIO registers are mapped differently, meaning the offsets used in Pi 4 no longer apply. Consequently, the GPIO+512 trick is not valid on Raspberry Pi 5.

It would translate something like this:

    // Request GPIO for Handshake pin
    status = devm_gpio_request(&pdev->dev, HANDSHAKE_PIN, "SPI_HANDSHAKE_PIN");
    if (status) {
        esp_err("Failed to obtain GPIO for Handshake pin, err:%d\n", status);
        return status;
    }

    // Set GPIO as input
    status = gpio_direction_input(HANDSHAKE_PIN);
    if (status) {
        esp_err("Failed to set GPIO direction of Handshake pin, err: %d\n", status);
        return status;
    }

    set_bit(ESP_SPI_GPIO_HS_REQUESTED, &spi_context.spi_flags);

    // Convert GPIO to IRQ
    irq = gpio_to_irq(HANDSHAKE_PIN);
    if (irq < 0) {
        esp_err("Failed to get IRQ for Handshake pin, err:%d\n", irq);
        return irq;
    }

    // Request IRQ
    status = devm_request_irq(&pdev->dev, irq, spi_interrupt_handler,
                              IRQF_SHARED | IRQF_TRIGGER_RISING,
                              "ESP_SPI", spi_context.esp_spi_dev);
    if (status) {
        esp_err("Failed to request IRQ for Handshake pin, err:%d\n", status);
        return status;
    }

Please note: this is just provided as reference, untested, non built code. Just to give you an idea or to maybe unblock you.

The proper fix would be needed in this case for Raspberry Pi 5. Anyway, the fix would be generic (agnostic of Raspberry Pi) as such (apart from the GPIO numbering).

[kapilkedawat]

@Shreyas0-7 could you help to check?

[savenlid]

The RPI is fresh out of the box, only used for this purpose so I have not allocated pins for other stuff.
Raspbian, fresh onto the SD cards some months ago, but left unused since then.
Updated now before starting with this "sudo apt update"

Without the +512 trick it did fail at an earlier stage as reported here in another issue.
Identical to that issue i think it was.

[savenlid]

https://www.thegoodpenguin.co.uk/blog/stop-using-sys-class-gpio-its-deprecated/

https://libgpiod.readthedocs.io/en/latest/index.html

[savenlid]

libbpiod 2.2 is not so easy.
its a wrapper around the ioctl world ( not a bad world I would say )

Its an abstraction that should supposedly should make the ioctl world easier for you.
But you get ultra-hard-clever-coded-hipster-c++17 examples that are not easy to understand.
Its also not back-compatible with the version that is a package, 1.6.xxx

But, the future is the future, so better not go backwards

Note:
you cannot have your libgpiod 1.6.xx package installed in parallel, it will give you compile errors
deinstall the package and the dev-package if installed.

apart from what is mentioned here:
https://libgpiod.readthedocs.io/en/latest/building.html

you must also get your c++ bindings

./configure --enable-tools=yes --enable-bindings-cxx
make
sudo make install

also:
sudo ldconfig to get that library into cache

I dechippered the set gpioset cxx example:
`// SPDX-License-Identifier: GPL-2.0-or-later
// SPDX-FileCopyrightText: 2017-2021 Bartosz Golaszewski bartekgola@gmail.com

/* Simplified C++ reimplementation of the gpioset tool. */

#include <gpiod.hpp>

#include
#include

int main(int argc, char **argv)
{
::gpiod::line::offset offset(3); // GPIO3

auto request = ::gpiod::chip("/dev/gpiochip0")	//  /dev/gpiochip0   for raspberry pi 5, may work for others
	.prepare_request()
	.set_consumer("gpiosetcxx")
	.add_line_settings(
		offset,		// 3
		::gpiod::line_settings()
			.set_direction(::gpiod::line::direction::OUTPUT)
	)
	.do_request();

request.set_value(offset, ::gpiod::line::value::ACTIVE);

::std::cin.get();   // just waits for a CR

request.set_value(offset, ::gpiod::line::value::INACTIVE);

return EXIT_SUCCESS;

}

`

[mantriyogesh]

Hello @savenlid ,

Our team is working on this this issue yet, we may take some time to resolve this correctly.
I request your patience and understanding on this.

cc @Shreyas0-7

[Shreyas0-7]

Hey @savenlid thanks for reporting the issue.
can you please follow these steps to apply a patch and try
cd /local_path/esp-hosted/esp_hosted_ng/host
git apply spi_gpio_v6.12.20.txt
and try again.
If you see issue regarding esp device not getting restart after rpi_init.sh spi command
please following the steps
Change the connection of cable from

Raspberry pi pin	ESP	Function
31	Don't change esp conenction	Reset

to

Raspberry pi pin	ESP	Function
29	Don't change esp conenction	Reset

That is connect ESP EN/RST pin cable to 29 of raspberry pin
and then apply this patch
git apply spi_gpio_v6.12.20_reset.txt

[savenlid]

Thank you.
I will give it a try as soon as time permits.

[mantriyogesh]

Hello @Dhanush-Adithiya10 ,

Ensure you use latest master both side (same commit) & follow all the config settings required from documentation.

If still face an issue, please create another issue. you can also cross reference this issue to let users or us know they might be related. Please attach logs while creating new issue to help better and fast: following esp and host side logs:

1. ESP

• git commit
• textual log from bootup

2. Linux

• dmesg from bootup

3. Close photo of esp and Linux connections (camera capture)
4. Confirm:

• Hardware connections as per documentation
• 'Free' GPIOs used and configured in Device Tree (if applicable. If unsure, just state unsure)
• If Raspberry Pi, which Raspberry Pi OS version
• Kernel version (uname -a could also help)

[mantriyogesh]

Hello @savenlid ,

Did the last change worked for you for RPi 5?

[savenlid]

@mantriyogesh

Hi This I did not have time to test.
Since I got it running towards the S3 togheter with dm9051 we can close that track and topic.
It was an experiment for an alternative track with a allwinner chip.