Skip to content

🐛 bug: Fix Content-Type comparison in Is() #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

Conversation

gaby
Copy link
Member

@gaby gaby commented Jun 23, 2025

Summary

  • handle parameters and casing when comparing MIME types in Ctx.Is.
  • update tests for case-insensitive comparison.
  • add test that mismatched subtype does not match.

@gaby gaby added the codex label Jun 23, 2025 — with ChatGPT Connector
Copy link
Contributor

coderabbitai bot commented Jun 23, 2025

Walkthrough

The Is method in the Ctx struct was updated to change how it matches the Content-Type header against a MIME type, switching from a prefix match to a case-insensitive exact match after removing parameters. Corresponding tests were added to verify correct handling of case, whitespace, and subtype mismatches.

Changes

File(s) Change Summary
ctx.go Updated Is method to use case-insensitive, parameter-stripped equality for Content-Type matching.
ctx_test.go Added test cases for case-insensitive, whitespace, and subtype handling in Is method.

Suggested labels

v3

Suggested reviewers

  • gaby
  • sixcolors
  • efectn

Poem

A rabbit hopped through headers bright,
Matching MIME types left and right.
Now case and spaces matter not,
Exactness is the match we sought!
With tests to check this clever feat—
Our code and carrots both taste sweet.
🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16e9ab4 and e7880b7.

📒 Files selected for processing (1)
  • ctx.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • ctx.go
⏰ Context from checks skipped due to timeout of 90000ms (17)
  • GitHub Check: Build (1.21.x, windows-latest)
  • GitHub Check: Build (1.21.x, macos-latest)
  • GitHub Check: Build (1.22.x, windows-latest)
  • GitHub Check: Build (1.20.x, windows-latest)
  • GitHub Check: Build (1.20.x, macos-latest)
  • GitHub Check: Build (1.19.x, macos-latest)
  • GitHub Check: Build (1.18.x, macos-latest)
  • GitHub Check: Build (1.19.x, windows-latest)
  • GitHub Check: Build (1.17.x, macos-latest)
  • GitHub Check: Build (1.19.x, ubuntu-latest)
  • GitHub Check: Build (1.18.x, ubuntu-latest)
  • GitHub Check: Build (1.18.x, windows-latest)
  • GitHub Check: Build (1.17.x, windows-latest)
  • GitHub Check: Analyse
  • GitHub Check: lint
  • GitHub Check: Compare
  • GitHub Check: govulncheck-check
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @gaby, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness and accuracy of the Ctx.Is method, which is responsible for content type comparison. The changes ensure that content type checks are more resilient to variations in header formatting, such as case differences, extraneous whitespace, and the presence of parameters, by implementing a more standard-compliant parsing and comparison logic.

Highlights

  • Improved Ctx.Is method logic: The Is method in ctx.go has been refactored to correctly parse and compare content types. It now extracts the primary content type by ignoring parameters (e.g., charset=utf-8), trims any leading or trailing whitespace, and performs a case-insensitive comparison using utils.EqualFold.
  • Enhanced test coverage for content type comparison: New test cases have been added to ctx_test.go to validate the improved Is method's behavior. These tests specifically cover scenarios involving case-insensitive comparisons with content types that include parameters (e.g., APPLICATION/JSON; charset=utf-8) and ensure correct handling of subtype mismatches (e.g., application/json+xml should not match json).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request improves the Is method in ctx.go to perform case-insensitive content type comparison and adds tests to verify the behavior. The changes involve trimming whitespace and folding case before comparison, and adding tests for case-insensitivity and subtype mismatch.

@gaby gaby changed the title Fix Is method content type comparison 🐛 bug: Fix Content-Type comparison in Is() Jun 23, 2025
@gaby gaby marked this pull request as ready for review June 23, 2025 02:27
@gaby gaby requested a review from a team as a code owner June 23, 2025 02:27
@ReneWerner87 ReneWerner87 merged commit 845f95f into v2 Jun 23, 2025
27 checks passed
@ReneWerner87 ReneWerner87 added this to the Next v2 release milestone Jun 23, 2025
@gaby gaby deleted the 2025-06-23-02-26-12 branch June 23, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants