apply IO error handling pattern to DefaultInvocationSerializer

Author: skastenholz

transactionoutbox-core/src/main/java/com/gruelbox/transactionoutbox/DefaultInvocationSerializer.java

@@ -1,16 +1,6 @@
 package com.gruelbox.transactionoutbox;
 
-import com.google.gson.Gson;
-import com.google.gson.GsonBuilder;
-import com.google.gson.JsonArray;
-import com.google.gson.JsonDeserializationContext;
-import com.google.gson.JsonDeserializer;
-import com.google.gson.JsonElement;
-import com.google.gson.JsonObject;
-import com.google.gson.JsonParseException;
-import com.google.gson.JsonSerializationContext;
-import com.google.gson.JsonSerializer;
-import com.google.gson.TypeAdapter;
+import com.google.gson.*;
 import com.google.gson.stream.JsonReader;
 import com.google.gson.stream.JsonToken;
 import com.google.gson.stream.JsonWriter;
@@ -106,8 +96,12 @@ public void serializeInvocation(Invocation invocation, Writer writer) {
   }
 
   @Override
-  public Invocation deserializeInvocation(Reader reader) {
-    return gson.fromJson(reader, Invocation.class);
+  public Invocation deserializeInvocation(Reader reader) throws IOException {
+    try {
+      return gson.fromJson(reader, Invocation.class);
+    } catch (JsonIOException | JsonSyntaxException exception) {
+      throw new IOException(exception);
+    }
   }
 
   private static final class InvocationJsonSerializer

transactionoutbox-core/src/test/java/com/gruelbox/transactionoutbox/AbstractTestDefaultInvocationSerializer.java

@@ -1,7 +1,11 @@
 package com.gruelbox.transactionoutbox;
 
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import java.io.IOException;
 import java.io.StringReader;
 import java.io.StringWriter;
+import java.io.UncheckedIOException;
 import java.time.*;
 import java.time.temporal.ChronoUnit;
 import java.util.*;
@@ -206,17 +210,27 @@ void testUUIDNull() {
     check(new Invocation(CLASS_NAME, METHOD_NAME, primitives, values));
   }
 
+  @Test
+  void testDeserializationException() {
+    assertThrows(
+        IOException.class, () -> serializer.deserializeInvocation(new StringReader("unparseable")));
+  }
+
   void check(Invocation invocation) {
     Invocation deserialized = serdeser(invocation);
     Assertions.assertEquals(deserialized, serdeser(invocation));
     Assertions.assertEquals(invocation, deserialized);
   }
 
   Invocation serdeser(Invocation invocation) {
-    var writer = new StringWriter();
-    serializer.serializeInvocation(invocation, writer);
-    log.info("Serialised as: {}", writer);
-    return serializer.deserializeInvocation(new StringReader(writer.toString()));
+    try {
+      var writer = new StringWriter();
+      serializer.serializeInvocation(invocation, writer);
+      log.info("Serialised as: {}", writer);
+      return serializer.deserializeInvocation(new StringReader(writer.toString()));
+    } catch (IOException e) {
+      throw new UncheckedIOException(e);
+    }
   }
 
   enum ExampleCustomEnum {