Fail on uncovered lines #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * wip * wip * wip * wip * wip * wip * removed dist Co-authored-by: ajiron <ajiron@liveperson.com>
|
Woah this is a pretty cool contribution! Thanks for all you work. Taking a look now. Just merged a bunch of dep updates so you'll have to merge master. |
|
@joeyjiron06 And updates to this? |
Co-authored-by: Andrew Lisowski <lisowski54@gmail.com>
|
@hipstersmoothie I updated the PR. let me know if you have any questsion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an optional parameter called
failOnUncoveredLineswhich if set to true, the reporter will comment on lines which were added in the pull request but have no code coverage. If false, then uncovered lines will not fail the build. See screenshots below.I also added a couple of test cases for some of the new code i wrote.
single line comment
multi-line comment
Rather than putting a comment on every line, I group sequential lines together in a single comment