Skip to content
This repository was archived by the owner on Feb 15, 2025. It is now read-only.

Commit db1b597

Browse files
committed
Fixed population of the <html> lang attribute default for quick commands6
1 parent 3163aad commit db1b597

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

CHANGES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
- Chunk sorting was removed, but it seems to work as before for the ordering of the JavaScript files generated by nwb's build.
88
- The plugin nwb uses to inline the webpack runtime chunk was rewritten to use v4's new hooks.
99

10+
## Fixed
11+
12+
- The `lang` attribute on `<html>` wasn't getting set to the default `'en'` when using the `nwb react`, `nwb preact` and `nwb inferno` quick development commands.
13+
1014
## Dependencies
1115

1216
- @babel/plugin-transform-react-jsx: v7.9.1 → [v7.9.4](https://github.com/babel/babel/releases/tag/v7.9.4)

src/quickCommands.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ export function createBuildConfig(args: Object, options: QuickConfigOptions) {
9393
},
9494
plugins: {
9595
html: {
96+
lang: 'en',
9697
mountId,
9798
title: args.title || defaultTitle,
9899
},
@@ -154,6 +155,7 @@ export function createServeConfig(args: Object, options: QuickConfigOptions) {
154155
},
155156
plugins: {
156157
html: {
158+
lang: 'en',
157159
mountId,
158160
title: args.title || defaultTitle,
159161
},

0 commit comments

Comments
 (0)