gptel-openai: gptel--request-data get reasoning capability from prop #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The models with reasoning capabilities were hard coded in openai's `gptel--request-data`. This commit replaces it with `gptel--model-capable-p` to get the reasoning capabilitie from the model properties.
ahmed-shariff
force-pushed
the
openai-get-reasoning-cap
branch
from
98d4d3f to
042091d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The models with reasoning capabilities were hard-coded in openai's
gptel--request-data. This PR replaces it withgptel--model-capable-pto get the reasoning capabilities from the model properties.This came about when I started playing with
gpt-4o-search-previewandgpt-4o-mini-search-preview, which seems to not supporttemperature. I was adding the reasoning capability, which seems to resolve that issue for now. Is it also worth consideringtemperatureas another capability?