upcoming: [M3-10267] - Address some loose ends with IP Table and Linode Interfaces #12473
+80
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…twice and Public IPv4 address hidden when public interface is default route
coliu-akamai
commented
Jul 3, 2025
Comment on lines
-371
to
-374
| // If there is a VPC interface with 1:1 NAT, hide the Public IPv4 IP address row | ||
| if (ipv4.vpc.find((vpcIp) => vpcIp.nat_1_1)) { | ||
| ipDisplay.shift(); | ||
| } |
There was a problem hiding this comment.
functionality moved into createPublicIPv4Display
coliu-akamai
requested review from
cpathipa,
harsh-akamai and
bnussman-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Jul 8, 2025
Cloud Manager UI test results🎉 675 passing tests on test run #6 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Notes - Linode Interfaces:
Changes 🔄
Preview 📷
row 1 - VPC interface is the default route
row 2 - public interface is the default route
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅