-
Notifications
You must be signed in to change notification settings - Fork 5
fix flaky recommender rerank_depth test #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keshav
previously approved these changes
May 13, 2025
VitusAcabado
previously approved these changes
May 14, 2025
keshav
previously approved these changes
May 14, 2025
VitusAcabado
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
create-indexes=True
parameter in cloud tests causes existing indexes to be deleted, which makes tests more annoying to deal with.What is the new behavior (if this is a feature change)?
test_tensor_search
has been updated for improved readability.README.dev.md
has been added under the tests/ directory, documenting how to properly run integration tests against both Open Source and Cloud environments, including GitHub Actions usage and cleanup procedures.create-indexes
flag has been updated: if set to True and the indexes already exist, they are now skipped rather than deleted, allowing tests to proceed without destructive actions.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: