added reranker property support #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
reviewed
Jan 9, 2023
| reranker_properties={"api_key": "f"} | ||
| ) | ||
| except MarqoWebError as e: | ||
| options = [["api", "key"], ["open", "ai"]] |
There was a problem hiding this comment.
Maybe we can add a comment here like "# test the format of the error message" for clarification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Reranker properties aren't available
What is the new behavior (if this is a feature change)?
Exposes reranker properties for search. This enables passing API keys, for use in GPT's API, for example.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: