Skip to content

Add types to sarc.cli.* #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2025
Merged

Add types to sarc.cli.* #223

merged 4 commits into from
Jun 19, 2025

Conversation

abergeron
Copy link
Collaborator

No description provided.

@lebrice
Copy link
Contributor

lebrice commented Jun 17, 2025

Hey @abergeron, en général (pour toutes les PRs qui ajoutent des types), est-ce que l'objectif c'est d'ajouter des annotations de type, mais de seulement faire semblant qu'ils sont respectés pour l'instant? (Exemple utiliser typing.cast(T, value) plutot que assert isinstance(value, T) ?)

@notoraptor notoraptor merged commit 2778c90 into master Jun 19, 2025
4 checks passed
@notoraptor notoraptor deleted the mypy_cli branch June 19, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants