fail! should return an array of rack response

Author: nov

lib/omniauth/strategies/apple.rb

@@ -106,12 +106,7 @@ def fetch_jwks
         end
         res = conn.get 'https://appleid.apple.com/auth/keys'
         if res.success?
-          jwks = res.body
-          if jwks.is_a?(Hash)
-            jwks
-          else
-            fail!(:jwks_fetching_failed, JWTFetchingFailed.new("Invalid format of JWKS returned: #{jwks}"))
-          end
+          res.body
         else
           fail!(:jwks_fetching_failed, JWTFetchingFailed.new('HTTP Error when fetching JWKs'))
         end

spec/omniauth/strategies/apple_spec.rb

@@ -265,7 +265,10 @@
 
     context 'fails nonce' do
       before(:each) do
-        expect(subject).to receive(:fail!).with(:nonce_mismatch, instance_of(OmniAuth::Strategies::OAuth2::CallbackError))
+        expect(subject).to receive(:fail!).with(
+          :nonce_mismatch,
+          instance_of(OmniAuth::Strategies::OAuth2::CallbackError)
+        ).and_return([302, {}, ''])
       end
       it 'when differs from session' do
         subject.session['omniauth.nonce'] = 'abc'
@@ -357,7 +360,7 @@
         expect(subject).to receive(:fail!).with(
           :jwks_fetching_failed,
           instance_of(OmniAuth::Strategies::Apple::JWTFetchingFailed)
-        )
+        ).and_return([302, {}, ''])
         subject.info
       end
     end
@@ -376,26 +379,7 @@
         expect(subject).to receive(:fail!).with(
           :jwks_fetching_failed,
           instance_of(Faraday::ParsingError)
-        )
-        subject.info
-      end
-    end
-
-    context 'when JWKS format is missing :keys' do
-      before do
-        stub_request(:get, 'https://appleid.apple.com/auth/keys').to_return(
-          body: 'true',
-          headers: {
-            'Content-Type': 'application/json'
-          }
-        )
-      end
-
-      it do
-        expect(subject).to receive(:fail!).with(
-          :jwks_fetching_failed,
-          instance_of(OmniAuth::Strategies::Apple::JWTFetchingFailed)
-        )
+        ).and_return([302, {}, ''])
         subject.info
       end
     end