Skip to content

Copyedit and fix textual and formatting errors in SDG form #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CAM-Gerlach
Copy link
Member

This fixes a number of basic typos, textual errors/issues (grammar, wording, phrasing, clarity), and formatting errors/inconsistencies (wording, quoting, capitalization, YAML syntax) in the SDG template, in addition to a light copyedit for clarity and correctness.

General fixes:

  • Use the clearer, more appropriate term "proposal" consistently to refer to a SDG proposal submission (instead of a mix of that, "submission" and even the ambiguous "project")
  • Consistently use quotes and no block scalars for (all single-line) description entries
  • Use consistent capitalization (sentence-case) for field labels

See PR comments for brief explanations of some specific changes.

@CAM-Gerlach CAM-Gerlach force-pushed the copyedit-sdg-template branch from 810fef3 to c66e7ce Compare May 27, 2025 04:08
Copy link
Member Author

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanations of non-trivial changes not mentioned above

Comment on lines -68 to +67
description: >-
"Who will implement this, what's the timeline, how will it be done"
description: "Who will implement this, what's the timeline, and how will it be carried out"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the spurious quotes in the block scalar here being unintentionally displayed in the output

validations:
required: true
- id: amount
type: input
attributes:
label: Amount requested
description: How much money is required to execute this proposal
description: "How much money is required to execute this proposal (max $10k)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well be explict about the limit

placeholder: "First name & Last name"
label: Submitter
description: "Who is submitting this request"
placeholder: "Full name"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid embedding the assumption that the ordering or structure of the submitter's name conforms to Western cultural norms

value: |
Complete the below fields to submit a Small Development Grant proposal.
Note that a project lead has to approve the proposal submission.
> [!IMPORTANT]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a more appropriate and less negative admonition type here

Comment on lines +12 to +13
Complete the below fields to submit a Small Development Grant proposal.
Note that a project lead has to approve the proposal submission.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use clearer and more appropriate wording

labels:
- Awaiting approval
body:
- id: instructions
type: markdown
attributes:
value: |+
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No obvious need to specify not normalizing trailing newlines (of which there is only the one anyway)

description: >-
What will be the imapct to the community if this project gets funded
description: "How will this proposal positively impact the community"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified and clarified this phrasing to be more direct and less awkward/unidiomatic. Also fixed a typo.

@CAM-Gerlach CAM-Gerlach marked this pull request as ready for review May 27, 2025 04:14
description: Which project is this proposal for? Comma separate them if this is a collaboration between different projects.
description: "Which NumFOCUS project is this proposal for (comma separate the names if a collaboration between multiple projects)"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was removing the question mark intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants