Skip to content

ci(lint): check old and new versions #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 15, 2025
Merged

ci(lint): check old and new versions #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8baf9fe
ci(pyproject): install older orjson for full compat check
ooliver1 May 20, 2025
38cf9d8
ci(lint): lint check nextcord v3
ooliver1 May 20, 2025
068bfa0
ci(lint): cache poetry based off python version and pyproject
ooliver1 May 20, 2025
f73d5ea
ci(lint): update pyright action
ooliver1 May 20, 2025
5289f07
ci: auto choose nextcord version
ooliver1 Jun 15, 2025
35bcbf4
typing: static type version check?
ooliver1 Jun 15, 2025
dfca63b
typing: type ignore health check
ooliver1 Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
fail-fast: false
steps:
- name: Check out repository
Expand All @@ -21,13 +21,13 @@ jobs:
id: setup-python
uses: actions/setup-python@v2
with:
python-version: 3.8
python-version: ${{ matrix.python-version }}

- name: Load cached Poetry installation
uses: actions/cache@v4
with:
path: ~/.local
key: poetry-0
key: poetry-${{ matrix.python-version }}-${{ hashFiles('**/pyproject.toml') }}

- name: Install Poetry
uses: snok/install-poetry@v1
Expand All @@ -44,7 +44,7 @@ jobs:
run: echo "PYRIGHT_VERSION=$(python -c 'import pyright; print(pyright.__pyright_version__)')" >> $GITHUB_ENV

- name: Run pyright (Linux)
uses: jakebailey/pyright-action@v1.4.1
uses: jakebailey/pyright-action@v2
with:
version: ${{ env.PYRIGHT_VERSION }}
python-version: ${{ matrix.python-version }}
Expand All @@ -54,7 +54,7 @@ jobs:
warnings: true

- name: Run pyright (Windows)
uses: jakebailey/pyright-action@v1.4.1
uses: jakebailey/pyright-action@v2
# run anyway
if: success() || failure()
with:
Expand Down
4 changes: 2 additions & 2 deletions mafic/__libraries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@
# Ignore RuntimeWarning as we import the warning to filter :}
simplefilter("ignore", RuntimeWarning)
try:
from nextcord.health_check import DistributionWarning
from nextcord.health_check import DistributionWarning # type: ignore
except ImportError:
# nextcord >= 3.0
pass
else:
simplefilter("ignore", DistributionWarning)
simplefilter("ignore", DistributionWarning) # type: ignore
finally:
simplefilter("always", RuntimeWarning)

Expand Down
7 changes: 5 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,14 @@ typing-extensions = "^4.3.0"
ruff = "^0.0.251"

[tool.poetry.group.lint.dependencies]
nextcord = "^2.0.0"
nextcord = [
{ version = "^3.0.1", python = "^3.12"},
{ version = "^2.0.0", python = "<3.12" },
]
disnake = "^2.0.0"
py-cord = "^2.0.0"
"discord.py" = "^2.0.0"
orjson = "^3.8.0"
orjson = "^3.5.0"

[tool.poetry.group.docs.dependencies]
sphinx = "^6.1.3"
Expand Down
Loading