feanil/prep pre move #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
feanil
commented
Oct 19, 2023
•
feanil
commented
- fix: Update docs spelling and grammer.
feanil
force-pushed
the
feanil/prep_pre_move
branch
from
345822d
to
7f5b73a
Compare
README.md
Outdated
| of this package can be found at | ||
| https://www.npmjs.com/package/@openedx/brand-openedx | ||
|
|
||
| This project contains the default branding assets and style used in Open edX | ||
| applications. It is published on npm as `@edx/brand-openedx`. | ||
| applications. It is published on NPM as `@edx/brand-openedx`. |
There was a problem hiding this comment.
Suggested change
| applications. It is published on NPM as `@edx/brand-openedx`. | |
| applications. It is published on npm as `@edx/brand-openedx`. |
npm is officially all lowercase https://en.wikipedia.org/wiki/Npm,_Inc., https://en.wikipedia.org/wiki/Npm
I'm not sure how we generally handle situations like this.
feanil
force-pushed
the
feanil/prep_pre_move
branch
from
b70c7b9
to
4b2ad66
Compare
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.