TRUNK-5950: RelationshipType to annotation #5037
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibacher please take a look in my PR and guide me. if there is something i did wrong. even if the checks failed. guide me on what to do. |
ibacher
reviewed
May 26, 2025
api/src/test/java/org/openmrs/propertyeditor/PatientIdentifierTypeEditorTest.java
Outdated
Show resolved
Hide resolved
ibacher
reviewed
May 26, 2025
ibacher
reviewed
May 26, 2025
|
@ibacher @dkayiwa any review here. and guidance if i did a mistake? I updated the nullable attribute to true to ensure that Hibernate schema validation passes. During testing, Hibernate reported that the name column was missing or mismatched in the relationship_type table. @anyone also help to direct me |
dkayiwa
reviewed
May 28, 2025
| @@ -174,8 +189,4 @@ public Integer getId() { | |||
| */ | |||
| @Override | |||
| public void setId(Integer id) { | |||
| setRelationshipTypeId(id); | |||
|
|
|||
| } | |||
|
@ibacher am i going to be worked on? |
ibacher
reviewed
Jun 24, 2025
| @@ -36,7 +37,7 @@ | |||
| public abstract class BaseOpenmrsMetadata extends BaseOpenmrsObject implements OpenmrsMetadata { | |||
|
|
|||
| //***** Properties ***** | |||
| @Column(name = "name", nullable = false, length = 255) | |||
| @Column(name = "name", nullable = true, length = 255) | |||
There was a problem hiding this comment.
This feels like something that should be done via an override rather than changing the base class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRUNK-5950: JRelationshipType Domain - Switching from Hibernate Mappings to Annotations'
Description of what I changed
Annotated RelationshipType with @entity, @table, @id, @column, etc.
Ensured all required fields (e.g., name) are correctly mapped and validated.
Verified that existing tests still pass after changes.
Issue I worked on
See the issue
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master