Trunk-5840: Migrate OrderGroup from Hibernate Mapping XML to JPA annotations #5100
Conversation
|
When i create a pr, it pulls the files for ProviderAttribute & ProviderRole as part of my commits yet i haven't made changes to them. Even the git status shows only 4 files. I've tried to clean the branch but i'm failing to get rid of the extra commits. Please guide me |
|
Jumping on the coffee break calls and sharing your screen can be a great way to help you with this. |
| private OrderGroup previousOrderGroup; | ||
|
|
||
| @OneToMany(mappedBy = "parentOrderGroup", cascade = CascadeType.ALL, orphanRemoval = true) | ||
| @OrderBy("orderGroupId") |
There was a problem hiding this comment.
Can we also map the batch size as was in the hibernate mapping file?
There was a problem hiding this comment.
This has been updated with batch size.
| private List<Order> orders; | ||
|
|
||
| @ManyToOne | ||
| @JoinColumn(name = "order_set_id") | ||
| private OrderSet orderSet; | ||
|
|
There was a problem hiding this comment.
Where is attributes being mapped?
There was a problem hiding this comment.
No action has been taken on this field yet because when i review the hbm file, i dont see the mapping for attributes. Kindly advise
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-5840
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master