Skip to content

Fix integration test includes #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 27, 2025
Merged

Conversation

DriesSchaumont
Copy link
Member

@DriesSchaumont DriesSchaumont commented May 23, 2025

Changelog

... Describe your changes ...

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont marked this pull request as ready for review May 23, 2025 12:29
@DriesSchaumont DriesSchaumont requested a review from rcannood May 23, 2025 12:29
@DriesSchaumont DriesSchaumont marked this pull request as draft May 23, 2025 12:53
@DriesSchaumont
Copy link
Member Author

DriesSchaumont commented May 23, 2025

Integration tests have been ran here: https://github.com/openpipelines-bio/openpipeline/actions/runs/15250403659
Failures are unrelated (the imports work)

@DriesSchaumont DriesSchaumont marked this pull request as ready for review May 23, 2025 13:27
rcannood
rcannood previously approved these changes May 26, 2025
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DriesSchaumont DriesSchaumont merged commit 015b920 into main May 27, 2025
4 checks passed
@rcannood rcannood deleted the fix_integration_test_includes branch May 27, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants