Updated requirements and added workaround for windows 10 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet, thanks for PR, will look into it tomorrow ;) |
povilasb
reviewed
Jan 9, 2021
| 'yarl==0.15.0', | ||
| 'beautifulsoup4==4.6.0', | ||
| 'tabulate==0.8.2', | ||
| 'click', |
There was a problem hiding this comment.
mmm, I don't like not freezing deps - builds can suddenly start failing for the same commit, hence worse reproducibility :/
povilasb
reviewed
Jan 9, 2021
| @@ -6,7 +6,9 @@ | |||
| import socket | |||
|
|
|||
| from . import core, proto | |||
|
|
|||
| selector = selectors.DefaultSelector() | |||
There was a problem hiding this comment.
Seems like this was fixed in curio itself: dabeaz/curio#159
Could you try just upgrading curio?
I don't ghave IGD enabled router now, neither Windows machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows will return immediately when trying to select() on three empty sets, this differs from the POSIX api which will block if given a timeout, this adds a dummy socket to the selectors as shown in dabeaz/curio#75. Also had some issues installing lxml on windows so removed requirement for version 4.1.1