reconfigure docker ports to stop providers from being accessed from the outside #1862
+6
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bundle-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes direct port mappings and expose entries for provider services to prevent them from being accessed from the host, and adds descriptive comments to the network definitions.
- Removed
portsandexposesettings for provider and MongoDB services - Added inline documentation to explain internal vs. external network behavior
Comments suppressed due to low confidence (1)
docker/docker-compose.provider.yml:45
- Hardcoding IPv4 addresses can lead to network conflicts and makes scaling harder; consider relying on Docker DNS for service discovery instead of static IPs.
ipv4_address: 172.18.0.3
|
needs testing on staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.