Update mmu-error-codes.yaml - add 508 FILAMENT_CHANGE #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you look at Marlin Marlin\src\feature\mmu3\mmu_hw\errors_list.h, you will see
FILAMENT_CHANGEis listed, but missing from the mmu-error-codes.yamlI am not sure about the
text:/text_short:, which I wrote for this PR, but any advice on what it should be please let me know.Either that we add this to the file, or we remove
ERR_SYSTEM_FILAMENT_CHANGEand all traces from the error_list.h file in Marlin repoRemoved
text_short: "More details online."from code XX306 because I submitted a PR to add long formatMSG_DESC_MMU_MCU_POWER_ERROR, and added a newMSG_DESC_MMU_MCU_UNDERVOLTAGE_VCC- just seems more important to say what actual error is than just"More details online."Updated README