Skip to content

ESLint and TSC fixes #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2022
Merged

ESLint and TSC fixes #79

merged 2 commits into from
Oct 19, 2022

Conversation

tdulcet
Copy link
Collaborator

@tdulcet tdulcet commented Oct 19, 2022

Note that I did not make all the needed fixes, just some of the low hanging fruit so to speak. Some of the JSDoc comments in your various libraries would also need to be fixed for the TypeScript compiler to work better.

If you agree with these changes, I can create a similar PR for the Awesome Emoji Picker.

@tdulcet tdulcet requested a review from rugk October 19, 2022 15:42
Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks, yeah that all LGTM.

@rugk rugk merged commit c67f355 into main Oct 19, 2022
@rugk rugk deleted the linting branch October 19, 2022 20:07
@rugk
Copy link
Owner

rugk commented Oct 19, 2022

And yeah, feel free to tackle these lib errors… 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants