Skip to content

Fix #652 - Use internal/user datetime to calculate GMT offset #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: hotfix
Choose a base branch
from

Conversation

scicali
Copy link

@scicali scicali commented Apr 16, 2025

Use internal(from db field) / user(from form field) datetime to calculate GMT offset

Description

Pass internal/user datetime value to UserTimeZone function. It uses current datetime now, so if you insert/view a datetime in same timezone but different DST, calculated GMT offset is wrong

Motivation and Context

Fix #652

How To Test This

See #652

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@mattlorimer mattlorimer added the PR 4-8 Complexity Score given to PRs once assessed label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR 4-8 Complexity Score given to PRs once assessed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sometimes datetime in list view not handle daylight saving time
2 participants