Skip to content

Missing or misplaced test for GLMS? #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jachymb opened this issue Feb 24, 2025 · 1 comment
Open

Missing or misplaced test for GLMS? #3152

jachymb opened this issue Feb 24, 2025 · 1 comment

Comments

@jachymb
Copy link

jachymb commented Feb 24, 2025 •
edited
Loading

The only GLM lpmf/lpdf test in test/unit/math/prim/prob/ seems to be for binomial_logit_lpdf

The other GLMs apparently only have tests in test/unit/math/rev/prob/

Maybe the files just should be split into two? I am not sure.
@jachymb jachymb changed the title Missing or misplaced test for categorical_logit_glm_lpmf? Missing or misplaced test for GLMS? Feb 24, 2025
@WardBrian
Copy link
Member

It looks like the rev files are also doing the tests that should belong in prim, if they were following the folder structure exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jachymb @WardBrian