Skip to content

feat(rich_text): Deprecate array argument richt_text twig filter #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2025

Conversation

silasjoisten
Copy link
Collaborator

Once this is merged i will deprecate array usage for this:

@trigger_deprecation('storyblok/symfony-bundle', '1.4', 'Passing an array to "%s" is deprecated, use "%s" instead.', __METHOD__, RichText::class);

@silasjoisten silasjoisten self-assigned this Jun 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (38202a0) to head (2ce1364).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
+ Coverage     92.94%   92.98%   +0.03%     
- Complexity      154      155       +1     
============================================
  Files            28       28              
  Lines           624      627       +3     
============================================
+ Hits            580      583       +3     
  Misses           44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@silasjoisten silasjoisten force-pushed the feature/allow-value-object-richtext branch from 7203e04 to 914d805 Compare July 12, 2025 09:37
@silasjoisten silasjoisten changed the title feat(rich_text): Allow RichText value object in twig extension feat(rich_text): Deprecate array argument richt_text twig filter Jul 12, 2025
@silasjoisten
Copy link
Collaborator Author

Ready to be reviewed an merged @OskarStark @edodusi

@silasjoisten silasjoisten changed the base branch from master to 1.x July 12, 2025 09:57
@silasjoisten silasjoisten merged commit 49c48cc into 1.x Jul 14, 2025
5 checks passed
@silasjoisten silasjoisten deleted the feature/allow-value-object-richtext branch July 14, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants