-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: Settings Window #2816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Settings Window #2816
Conversation
|
||
namespace Stride.Core.Assets.Editor.Settings; | ||
|
||
public static class EditorSettings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why make it a singleton?
it forces to have only one setting, what about swapping between settings etc, no need for it to be singleton and static?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by swapping between settings? Can you explain the use cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have a folder with X different settings bundles and you should be able to swap between them
like there is no reason for it to be singleton, graphicscontext is also not a singleton for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you have different bundles of settings files for the editor? Those are basic settings like theme, language, list of recent projects, etc.
If you think about having several user profiles, that could be a new feature but it is out of scope for the rewrite effort. Here I'm just porting the existing settings system from the old editor, and such feature is not implemented there either. Feel free to open a feature request.
a93dd8b
to
f51fa5c
Compare
f51fa5c
to
519fcb5
Compare
PR Details
Adds a Window for editing the settings.
Types of changes
Checklist