Skip to content

feat: Settings Window #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025

Conversation

Kryptos-FR
Copy link
Member

PR Details

Adds a Window for editing the settings.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR Kryptos-FR added this to the Editor Rewrite - Phase 2 milestone Jun 13, 2025
@Kryptos-FR Kryptos-FR self-assigned this Jun 13, 2025
@Kryptos-FR Kryptos-FR added area-GameStudio work-estimate-S Good for first timers. A relatively quick item to fix, Max of 2x of XS labels Jun 13, 2025

namespace Stride.Core.Assets.Editor.Settings;

public static class EditorSettings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why make it a singleton?
it forces to have only one setting, what about swapping between settings etc, no need for it to be singleton and static?

Copy link
Member Author

@Kryptos-FR Kryptos-FR Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by swapping between settings? Can you explain the use cases?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have a folder with X different settings bundles and you should be able to swap between them
like there is no reason for it to be singleton, graphicscontext is also not a singleton for example

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you have different bundles of settings files for the editor? Those are basic settings like theme, language, list of recent projects, etc.

If you think about having several user profiles, that could be a new feature but it is out of scope for the rewrite effort. Here I'm just porting the existing settings system from the old editor, and such feature is not implemented there either. Feel free to open a feature request.

@Kryptos-FR Kryptos-FR marked this pull request as ready for review June 17, 2025 13:36
@Kryptos-FR Kryptos-FR force-pushed the feature/xplat/settings branch from a93dd8b to f51fa5c Compare June 17, 2025 13:37
@Kryptos-FR Kryptos-FR force-pushed the feature/xplat/settings branch from f51fa5c to 519fcb5 Compare June 17, 2025 14:41
@Kryptos-FR Kryptos-FR merged commit 502874c into stride3d:xplat-editor Jun 17, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Avalonia Editor Rewrite Jun 17, 2025
@Kryptos-FR Kryptos-FR deleted the feature/xplat/settings branch June 17, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-GameStudio work-estimate-S Good for first timers. A relatively quick item to fix, Max of 2x of XS
Projects
Development

Successfully merging this pull request may close these issues.

2 participants