Skip to content

feat: styles for theme variants #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 19, 2025
Merged

feat: styles for theme variants #2819

merged 7 commits into from
Jun 19, 2025

Conversation

Kryptos-FR
Copy link
Member

@Kryptos-FR Kryptos-FR commented Jun 17, 2025 •
edited
Loading

PR Details

The Fluent theme that we are using has two variants: dark and light. Instead of hard-coding values (such as colors), we will use the corresponding resource keys to ensure consistency.

In addition, this theme supports having an "accent" color. Modern desktop (Windows, Linux) let the user define which accent they want for their apps. So we should take that into account.

Related Issues

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR Kryptos-FR added this to the Editor Rewrite - Phase 2 milestone Jun 17, 2025
@Kryptos-FR Kryptos-FR self-assigned this Jun 17, 2025
This was linked to issues Jun 17, 2025
⬇️🟢𝐌 Write styles for dark theme 🎨🌛 #2817
Closed
⬇️🟢𝐌 Write styles for light theme 🎨🌞 #2818
Closed
@Kryptos-FR Kryptos-FR moved this to In Progress in Avalonia Editor Rewrite Jun 17, 2025
@Kryptos-FR Kryptos-FR added area-GameStudio work-estimate-L 2-7 Days of work. Should try to break down into smaller issues labels Jun 17, 2025
@Kryptos-FR Kryptos-FR force-pushed the feature/xplat/theme-variants branch from 493c6fa to 0f78202 Compare June 17, 2025 16:17
@Kryptos-FR Kryptos-FR force-pushed the feature/xplat/theme-variants branch from 0f78202 to 316ab41 Compare June 18, 2025 10:08
@Kryptos-FR Kryptos-FR marked this pull request as ready for review June 18, 2025 10:09
@Kryptos-FR Kryptos-FR force-pushed the feature/xplat/theme-variants branch from 316ab41 to 57d6720 Compare June 18, 2025 10:21
@Kryptos-FR Kryptos-FR moved this from In Progress to Review in Avalonia Editor Rewrite Jun 18, 2025
@Kryptos-FR Kryptos-FR merged commit 9d35589 into stride3d:xplat-editor Jun 19, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Avalonia Editor Rewrite Jun 19, 2025
@Kryptos-FR Kryptos-FR deleted the feature/xplat/theme-variants branch June 19, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kryptos-FR Kryptos-FR

Labels
area-GameStudio work-estimate-L 2-7 Days of work. Should try to break down into smaller issues
Projects
Avalonia Editor Rewrite
Status: Done
Milestone
Editor Rewrite - Phase 2
Development

Successfully merging this pull request may close these issues.

⬇️🟢𝐌 Write styles for light theme 🎨🌞 ⬇️🟢𝐌 Write styles for dark theme 🎨🌛
1 participant
@Kryptos-FR