Use via extractor's rejection instead of axum::response::Response
#3261
+39
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mladedav
approved these changes
Mar 27, 2025
|
A changelog entry would be nice. |
|
Regarding this being a breaking change - I guess we want to be on the safe side after the last release but it's true this was always just a bug since it's explicitly documented as using the other rejection. But to be clear, do we want to wait for 0.9 before releasing this? |
|
Yeah I'd like to wait. Maybe for 0.8 we should adjust the docs to reality. |
kyle-nweeia
force-pushed
the
fix-fromrequestparts-rejection
branch
from
3824063 to
8498db9
Compare
|
@jplatte do these changelog updates look correct? |
|
Yeah, looks good. Thanks! |
kyle-nweeia
force-pushed
the
fix-fromrequestparts-rejection
branch
from
95dcc3a to
07dfa7a
Compare
jplatte
approved these changes
May 1, 2025
|
Looks like this needs a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3160.
Makes the
from_requestattribute use the rejection type assigned to the extractor by theFromRequestorFromRequestPartsimplementation. This brings it in line with the behavior documented at https://docs.rs/axum/latest/axum/extract/derive.FromRequest.html#the-whole-type-at-once.Updates two tests that expected the extractor rejection to be
axum::response::Response.