Skip to content

Cancellation safety for WebSocket's async methods is not documented #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ProgramCrafter opened this issue Mar 22, 2025 · 0 comments
Open

Comments

@ProgramCrafter
Copy link

Docs don't say if the following code is correct or may produce unexpected results:

  let update_receiver: tokio::sync::broadcast::Receiver;
  let sock: axum::extract::ws::WebSocket;
  
  let (mut ws_write, mut ws_read) = sock.split();

  tokio::select! {
    // Cancel-safe. https://docs.rs/tokio/1.43.0/tokio/sync/broadcast/struct.Receiver.html#cancel-safety
    clientbound = update_receiver.recv() => {...}
    // ??? https://docs.rs/axum/0.8.1/axum/extract/ws/struct.WebSocket.html#method.recv
    serverbound = ws_read.recv() => {...}
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant