Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid tar.gz created when there is a unicode filename #230

Open
vti opened this issue Oct 25, 2017 · 4 comments
Open

Invalid tar.gz created when there is a unicode filename #230

vti opened this issue Oct 25, 2017 · 4 comments

Comments

@vti
Copy link
Contributor

vti commented Oct 25, 2017

When building a distribution with a unicode filename inside a .tar.gz is created but when unpacking:

tar: Skipping to next header
tar: Child returned status 1
tar: Error is not recoverable: exiting now

Removing the unicode file fixes the problem.

@skaji
Copy link
Collaborator

skaji commented Oct 25, 2017

As mentioned in #228, I don't think minil should support such distributions.

OTOH, it could be nice if minil emits some helpful warnings then.

@vti
Copy link
Contributor Author

vti commented Oct 25, 2017

Strange, I sometimes have unicode files for testing for example.

@karenetheridge
Copy link

Non-ascii characters in filenames in cpan distributions "should" be okay, as long as they are not files that get installed (lib/.pm, bin/ etc), because we do not know what kind of filesystem the user will be installing on. However, Test::Portability has a more limited character set that it checks for, to handle ideosyncracies on various filesystems. Also see the Acme-LookOfDisapproval distribution for pitfalls arising from special characters in .pm files.

@skaji
Copy link
Collaborator

skaji commented Oct 26, 2017

@karenetheridge Thanks for clarifying the current status of CPAN distributions which have non-ascii characters in their filenames.
It's very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants