Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: minil build, dist, release should support --trial and adjust release_status #262

Open
cxw42 opened this issue Apr 26, 2019 · 2 comments

Comments

@cxw42
Copy link
Contributor

cxw42 commented Apr 26, 2019

minil release supports the --trial option that changes the tgz filename. However, it still shows the release_status as stable (unless I'm doing something wrong; see example). For consistency, would you be willing to make two changes?

  • set release_status to testing if --trial is given
  • support --trial on minil build and minil dist

That way I could see the full code to be released using build or dist before actually running release. Please let me know your thoughts. Thank you!

@cxw42 cxw42 changed the title Request: minil build and minil dist should support --trial Request: minil build, dist, release should support --trial and adjust release_status Apr 26, 2019
@skaji
Copy link
Collaborator

skaji commented Apr 27, 2019

set release_status to testing if --trial is given

I agree. We should set release_status testing.

support --trial on minil build and minil dist

I don't think so. Minilla sets release_status unstable intentionally if it is in a git repository.

@cxw42
Copy link
Contributor Author

cxw42 commented Apr 28, 2019

@skaji Thank you for your comment!

Minilla sets release_status unstable intentionally if it is in a git repository.

That makes sense. However, I am confused. On my system, I do not see this behaviour. See, e.g., https://github.com/tokuhirom/Minilla/blob/v3.1.4/lib/Minilla/Project.pm#L420 - release_status is set for underscore versions, but I do not see a test for being in a git repository.

I see the following:

$ minil new Acme-Foo
$ cd Acme-Foo
$ git remote add upstream https://cxw42@github.com/cxw42/Acme-Foo.git
$ minil build
$ grep release_status Acme-Foo*/*
Acme-Foo-0.01/META.json:   "release_status" : "stable",
Acme-Foo-0.01/MYMETA.json:   "release_status" : "stable",

Would you be willing to try this, or let me know what I'm missing? Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants