Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release.hooks do not run at 'minil dist' #304

Open
halcon74 opened this issue Mar 6, 2021 · 2 comments
Open

release.hooks do not run at 'minil dist' #304

halcon74 opened this issue Mar 6, 2021 · 2 comments

Comments

@halcon74
Copy link

halcon74 commented Mar 6, 2021

Hi!

Thank you for your product! I like it. I am still studying how to use it properly :) And I've got a question.

When running 'minil release', release.hooks are being executed before making tarball, but when running 'minil dist' - are not. Is it by design or an issue?

I made a patch fixing that (and tested, it works). If it could be, in principle, accepted, I am ready to open a PR.

@skaji
Copy link
Collaborator

skaji commented Mar 6, 2021

As the name suggests, release.hooks are executed in minil release by design.

@halcon74
Copy link
Author

halcon74 commented Mar 6, 2021

OK. And, you think, there is no reason to make them available for 'dist'? Maybe, under other section ("dist.hooks")?

I think that would be logical, because, when running 'release', the hooks are executed before creating tarball, so, the tarball is being created with the changes that the hooks applied. And the same tarball, currently, is being created without these changes, when running 'dist'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants