Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring Git remote used to generate meta resources #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nohuhu
Copy link

@nohuhu nohuhu commented Apr 27, 2018

When Git remote pointing to the master repo is not origin (say, upstream), Minilla will try to override meta resources with Git URLs generated from origin remote.

Allowing to configure what remote is used solves this problem.

@Grinnz
Copy link
Contributor

Grinnz commented Apr 27, 2018

I'm not sure this is the optimal way to configure this. Remember the minil.toml is committed, and so needs to work for the owner as well as any contributors, who may have different remote setups.

@nohuhu
Copy link
Author

nohuhu commented Apr 27, 2018

Right, I was writing a comment describing the changes and realized that this might be the case. Any input on how to make this configurable on local basis? Environment variable perhaps?

@Grinnz
Copy link
Contributor

Grinnz commented Apr 27, 2018

There's two ways it could be configured in minil.toml that would work for all users. Either setting the github user (or perhaps user/repo) to override the one found in the origin remote (only if it's a github URL, of course) or setting the URL to use as a whole.

@nohuhu
Copy link
Author

nohuhu commented Apr 28, 2018

I see another way: add optional and non-committed minil_local.toml that would override config values in the main minil.toml. That would make it easy to change any values without conflicting with other people's repo forks.

@tokuhirom Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants