export Close() method for subscopes #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Close() method to Scope interface to allow explicit cleanup of subscopes. This enables better resource management by allowing clients to: - Clear metrics for unused subscopes - Remove scopes from registry - Release associated resources The method is idempotent and thread-safe, returning an error if the scope is already closed.
|
|
prateek
requested changes
May 21, 2025
| // For root scopes, this will also close the reporter. | ||
| // For subscopes, this will clear all metrics and remove the scope from the registry. | ||
| // Returns an error if the scope is already closed. | ||
| Close() error |
There was a problem hiding this comment.
can't do this - it's a breaking change to add a method to a go interface in semver terms
There was a problem hiding this comment.
I've introduced a new ClosableScope interface to embed Scope with a Close() method
…ards-compatible way - Introduce ClosableScope interface embedding Scope with Close() method - Add NewClosableRootScope, TaggedClosable, and SubScopeClosable methods to obtain subscopes as ClosableScope - Add unit tests for new ClosableScope functionality - Preserve semver compatibility by not modifying Scope interface or method signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ClosableScope interface to embed Scope and expose a Close() method to allow explicit cleanup of subscopes. This enables better resource management by allowing clients to:
Clear metrics for unused subscopes
Remove scopes from registry
Release associated resources
The method is idempotent and thread-safe, returning an error if the scope is already closed.