Skip to content

fix: send failure / skipped results to discord #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

sapphi-red
Copy link
Member

#388 made failure results and skipped results to be not sent to discord. This PR fixes that.

always() && condition seems to be the way to do this.
https://github.com/search?q=%2Falways%5C(%5C)+%26%26%2F+language%3Ayaml&type=code

Probably this is how we can understand the behavior:

I would have expected the default value of if: success() to be replaced with if: <your_condition>, but it's actually if: success() && <your_condition> unless your condition includes one of the status functions
— quoted from actions/runner#491 (comment)

@dominikg dominikg merged commit b886c61 into main Jun 9, 2025
4 checks passed
@dominikg dominikg deleted the fix/send-failure-results-to-discord branch June 9, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants