fix: align execute-all matrix and workflow_dispatch option #397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed
one
is missing inexecute-all
#360 (which means PR CI run doesn't includeone
). I asked copilot to check others and foundreact-router
, so I fixed that too.copilot chat log
hi-ogawa: there are two lists for
suite
. check the differenceGitHub Copilot: The
suite
option inon.workflow_dispatch.inputs.suite.options
defines the choices available when the workflow is manually dispatched. Thesuite
list injobs.execute-all.strategy.matrix.suite
defines the suites that run when all test suites are selected (inputsuite
is'-'
).Here's the difference between the two lists:
Suites present in
inputs.suite.options
but not injobs.execute-all.strategy.matrix.suite
:-
(This is a special value to run all suites)hydrogen
(Commented out inmatrix.suite
:# - hydrogen # disabled until they complete they migration back to Vite
)iles
(Commented out inmatrix.suite
:# - iles # disabled until its CI is fixed
)nx
(Commented out inmatrix.suite
:# - nx # disabled temporarily
)one
vite-plugin-react-pages
(Commented out inmatrix.suite
:# - vite-plugin-react-pages # # disabled until its install setup is fixed
)redwoodjs
(Commented out in both, but present as an option)Suites present in
jobs.execute-all.strategy.matrix.suite
but not ininputs.suite.options
:react-router