Skip to content

fix: align execute-all matrix and workflow_dispatch option #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jun 13, 2025

I noticed one is missing in execute-all #360 (which means PR CI run doesn't include one). I asked copilot to check others and found react-router, so I fixed that too.

copilot chat log

hi-ogawa: there are two lists for suite. check the difference

GitHub Copilot: The suite option in on.workflow_dispatch.inputs.suite.options defines the choices available when the workflow is manually dispatched. The suite list in jobs.execute-all.strategy.matrix.suite defines the suites that run when all test suites are selected (input suite is '-').

Here's the difference between the two lists:

Suites present in inputs.suite.options but not in jobs.execute-all.strategy.matrix.suite:

  • - (This is a special value to run all suites)
  • hydrogen (Commented out in matrix.suite: # - hydrogen # disabled until they complete they migration back to Vite)
  • iles (Commented out in matrix.suite: # - iles # disabled until its CI is fixed)
  • nx (Commented out in matrix.suite: # - nx # disabled temporarily)
  • one
  • vite-plugin-react-pages (Commented out in matrix.suite: # - vite-plugin-react-pages # # disabled until its install setup is fixed)
  • redwoodjs (Commented out in both, but present as an option)

Suites present in jobs.execute-all.strategy.matrix.suite but not in inputs.suite.options:

  • react-router

@patak-dev patak-dev merged commit 84ba1ee into vitejs:main Jun 13, 2025
1 check passed
@hi-ogawa hi-ogawa deleted the fix-one-in-execute-all branch June 13, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants