-
-
Notifications
You must be signed in to change notification settings - Fork 810
Hide floating tab bar on iPad when scrolling #5200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice the tab bar can get "stuck" in a hidden state when the content is short. I faced a similar issue with the navigation bar hiding - you can reference calculateNavigationBarHiddenState
for how I fixed. Not a must-fix though, in my opinion, as long as design review is good with it.
in.mov
Per design, we need a bug fixed so that the floating tab bar is not stuck in a hidden state.
Phabricator: https://phabricator.wikimedia.org/T383759
Notes
Test Steps