Skip to content

Remove YIR entry points #5334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 30, 2025
Merged

Remove YIR entry points #5334

merged 13 commits into from
Jul 30, 2025

Conversation

l-olson1214
Copy link
Collaborator

@l-olson1214 l-olson1214 commented Jun 23, 2025 •
edited
Loading

Phabricator:
https://phabricator.wikimedia.org/T383160

Notes

Test Steps

  1. Ensure entry points are removed

Screenshots/Videos

@l-olson1214 l-olson1214 requested a review from mazevedofs June 23, 2025 18:23
@l-olson1214 l-olson1214 added the Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging label Jun 23, 2025
@l-olson1214 l-olson1214 changed the title Remove YIR entry points Remove YIR entry points Jun 23, 2025
mazevedofs
mazevedofs requested changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one suggestions so we don't need to comment large parts of the code and we're able to easily test in dev.

@mazevedofs mazevedofs removed the 7.7.8 label Jul 11, 2025
mazevedofs
mazevedofs requested changes Jul 11, 2025
View reviewed changes
@l-olson1214 l-olson1214 changed the base branch from main to T381678_yir-cleanup July 14, 2025 18:54
@l-olson1214 l-olson1214 requested a review from mazevedofs July 14, 2025 19:38
@mazevedofs mazevedofs added the 7.8.1 Tabs V2 - hidden label Jul 30, 2025
Base automatically changed from T381678_yir-cleanup to main July 30, 2025 14:12
@l-olson1214 l-olson1214 added 7.8.1 Tabs V2 - hidden and removed 7.8.1 Tabs V2 - hidden labels Jul 30, 2025
@l-olson1214 l-olson1214 merged commit c155f25 into main Jul 30, 2025
5 of 6 checks passed
@l-olson1214 l-olson1214 deleted the hide-yir branch July 30, 2025 14:30
@tonisevener tonisevener mentioned this pull request Aug 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazevedofs mazevedofs

Assignees
No one assigned
Labels
7.8.1 Tabs V2 - hidden Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l-olson1214 @mazevedofs @tonisevener