Skip to content

feat: Drag and Drop link to split #8773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: dev
Choose a base branch
from

Conversation

octaviusz
Copy link
Contributor

This PR introduces the ability to create or extend split views by dragging and dropping a link. The placement of the new split tab is determined by the drop location on the target area, allowing for intuitive directional splitting.

recording_2025-06-01_21.53.05.mp4

@octaviusz octaviusz requested a review from mr-cheffy June 1, 2025 18:58
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Feature labels Jun 1, 2025
Copy link
Contributor

@mr-cheffy mr-cheffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@octaviusz octaviusz force-pushed the drop-link-to-split branch from a0a11da to d8910be Compare June 1, 2025 21:04
@octaviusz octaviusz requested a review from mr-cheffy June 3, 2025 12:10
Copy link
Contributor

@mr-cheffy mr-cheffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes! I was wondering if you could also write tests for these. It's fine if you can't, don't worry.

@octaviusz octaviusz requested a review from mr-cheffy June 7, 2025 14:32
@LemonPotion
Copy link

@mr-cheffy , can you review this pr? I think the @octaviusz resolved all of the issues.

Thank you for your hard work❤️

@mr-cheffy
Copy link
Contributor

Yeah, it'll be merged on the next release cycle

@MiraiDevv
Copy link

Just to clear my conscience, I don't know if this is only in the mod or if it happens natively within Zen, but in the drag and drop mod using link to split, it is not working in either Twilight or 1.13.2, but I don't know if it would be because of the version or something like that, anyway, be warned! (the mod was downloaded and installed by sine).

@octaviusz
Copy link
Contributor Author

@MiraiDevv This is Sine issue. All issues with the mod please leave in the mod repository and not here

@MiraiDevv
Copy link

@MiraiDevv This is Sine issue. All issues with the mod please leave in the mod repository and not here

Ok! Just reporting, because I thought it might not be working within Zen natively, I just don't have a good enough computer to build it, if not I would build it to take a look, anyway, I'm sorry if I caused any inconvenience.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 11, 2025
@mr-cheffy mr-cheffy self-requested a review July 11, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants