-
-
Notifications
You must be signed in to change notification settings - Fork 970
feat: Drag and Drop link to split #8773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
a0a11da
to
d8910be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes! I was wondering if you could also write tests for these. It's fine if you can't, don't worry.
Signed-off-by: mr. m <91018726+mauro-balades@users.noreply.github.com>
Signed-off-by: mr. m <91018726+mauro-balades@users.noreply.github.com>
@mr-cheffy , can you review this pr? I think the @octaviusz resolved all of the issues. Thank you for your hard work❤️ |
Yeah, it'll be merged on the next release cycle |
Just to clear my conscience, I don't know if this is only in the mod or if it happens natively within Zen, but in the drag and drop mod using link to split, it is not working in either Twilight or 1.13.2, but I don't know if it would be because of the version or something like that, anyway, be warned! (the mod was downloaded and installed by sine). |
@MiraiDevv This is Sine issue. All issues with the mod please leave in the mod repository and not here |
Ok! Just reporting, because I thought it might not be working within Zen natively, I just don't have a good enough computer to build it, if not I would build it to take a look, anyway, I'm sorry if I caused any inconvenience. |
This PR introduces the ability to create or extend split views by dragging and dropping a link. The placement of the new split tab is determined by the drop location on the target area, allowing for intuitive directional splitting.
recording_2025-06-01_21.53.05.mp4