Skip to content

Fix browser-ctrlTab-js patch for Firefox 140.0 compatibility #9148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

markzakharyan
Copy link

@markzakharyan markzakharyan commented Jun 23, 2025

Summary

This PR fixes the browser-ctrlTab-js.patch file to work with Firefox 140.0, resolving the init script failure during patch application. Note that this is my first contribution to this repo so please be kind if what I did doesn't make any sense :).

Changes Made

  • Updated patch to work with Firefox 140.0 changes
  • Removed obsolete open function modification (already included in Firefox 140.0)
  • Updated line numbers to match current ctrlTab.js structure
  • Fixes the npm run init command that was failing due to patch application errors

Testing

  • npm run init now completes successfully without patch errors
  • All 166 patches apply correctly
  • Language pack update works properly

Issue

This fixes the build setup issue where the init script was failing with patch application errors. The patch was trying to modify code that had already been updated in Firefox 140.0, causing conflicts during the build setup process. This also fixes ctrl+shift+tab behavior when the "Ctrl+Tab cycles through tabs in recently used order" setting is enabled.

- Update patch to work with Firefox 140.0 changes
- Remove obsolete open function modification (already included in Firefox)
- Update line numbers to match current ctrlTab.js structure
- Fixes init script failure during patch application
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Bug labels Jun 23, 2025
@mr-cheffy
Copy link
Contributor

Tab count is necessary though, why remove it?

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 24, 2025
@markzakharyan markzakharyan force-pushed the fix/firefox-140-ctrltab-patch branch from 7ba507c to 1d86add Compare June 24, 2025 01:37
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 24, 2025
@markzakharyan
Copy link
Author

Removing tabCount was how I got ctrl+shift+tab to work when the "Ctrl+Tab cycles through tabs in recently used order" setting is enabled. ideally, i would want this to just cycle back in the tab index instead of just not doing anything, which was the previous behavior.

@mr-cheffy
Copy link
Contributor

It crashes the browser if there are no tabs on some occasions. See #7865

@mr-cheffy mr-cheffy closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants