Try to detect fancy formatting using Unicode math characters #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9.
Tested and seems to be working:
fancyFormattingGrammar.json
, are my messages any good? Happy to accept any and all feedback on how to make this approachable and encouraging and useful.Small code changes:
sendPrivateStatus
making the random string, it's callerprocessDeleteEvent
does that instead. The motivation for this is that the latter has the information about whether this is about captions or about fancy formatting.processDeleteEvent
easy to understand I hope.fancyFormatting.js
that's basically a wrapper around a single regexp. It has a built-in mini-test (if you runnode js/fancyFormatting.js
it'll run the mini-test)—happy to move this into a proper unit test in atests/
directory and add it topackage.json
. The comment at the top of the file describes some technical shortcuts that I took, happy to answer questions about that.