New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kuma-cp) use cmux for MADS server #1887
Conversation
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! 👏
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@@ -0,0 +1,140 @@ | |||
package server_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice test!
Should we add the same to the dp-server @lobkovilya? kuma/pkg/dp-server/server/server.go Lines 104 to 110 in 10936f8
Or is this always run with TLS so it doesn't matter? |
Summary
The existing approach of multiplexing GRPC and HTTP/1.1 on the same port doesn't work without TLS. Instead, library cmux works pretty well, that's why current PR replaces the existing approach with
cmux
.Change default version of MADS API to v1alpha1 because of #1886
Full changelog
cmux
v1alpha1