Skip to content

Comments

Update to zig 0.13.0#58

Closed
PalanixYT wants to merge 1 commit into00JCIV00:mainfrom
PalanixYT:0.13.0
Closed

Update to zig 0.13.0#58
PalanixYT wants to merge 1 commit into00JCIV00:mainfrom
PalanixYT:0.13.0

Conversation

@PalanixYT
Copy link

I've tried to update the codebase. All tests and examples compile/pass.
Sadly zig fmt fucked up everything. If you're still willing to merge, that would be great. If not, you can just snatch the edits from this pr

@00JCIV00
Copy link
Owner

@PalanixYT really appreciate you looking to update the library! Zig v0.13.0 support is actually already available in the Cova v0.10.1 branch. Please try that and let me know if you run into any issues.

Separate but related, once I release v0.10.1 I'll move back to a model where the main branch in the nightly/in progress release and the the other branches will just line up with the release tags. This should help avoid some of the confusion on the most recent version of Cova.

@PalanixYT
Copy link
Author

Oh my apologies then! I thought that those tags referred to the zig version they compile against

@PalanixYT
Copy link
Author

PalanixYT commented Jul 17, 2024

I've tried doing it and I've found two things:

  • Test and basic-app fail because displayCmdInfo is missing the last boolean
  • basic-app will fail because writeFile isn't called correctly. You can find the fix in my pr though

@PalanixYT PalanixYT closed this Jul 17, 2024
@00JCIV00
Copy link
Owner

Oh my apologies then! I thought that those tags referred to the zig version they compile against

That's understandable, haha. If you have any further thoughts on how I can delineate that, I'm open to suggestions.

I've tried doing it and I've found two things:

  • Test and basic-app fail because displayCmdInfo is missing the last boolean
  • basic-app will fail because writeFile isn't called correctly. You can find the fix in my pr though

Good find! I'll have those updated quickly next time I'm at a computer. A big part of the v0.11 update is setting up proper tests to avoid some of these smaller mistakes.

@PalanixYT
Copy link
Author

PalanixYT commented Jul 18, 2024

Oh my apologies then! I thought that those tags referred to the zig version they compile against

That's understandable, haha. If you have any further thoughts on how I can delineate that, I'm open to suggestions.

The thing that made me think most that those tags refer to older versions was that the documentation still had slightly older code syntax (just the position of a const keyword in the string) and I projected that idea on the entire code.

That being said, just from the looks of this project, this is insane. It's downright beautiful what cova can do with comptime

00JCIV00 added a commit that referenced this pull request Jul 18, 2024
- Updated Basic App Example f/ Cova v0.10.0 and Zig v0.13.0 changes.
- Updated Tests f/ Cova v0.10.0 changes.
- Thank you @PalanixYT for pointing these out! #58
@00JCIV00
Copy link
Owner

Much appreciated! I'll continue to work on the README so it lines up better with the latest Zig trends. More importantly though, I'm glad Cova's comptime features drew you in. I've still got a few more features in the works that I think you'll really like.

Separately, those issues have been resolved on the latest v0.10.1 commit. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants