New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widgets] "previous page" becomes a target #186

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@maxyu
Contributor

maxyu commented Aug 3, 2012

No description provided.

@@ -61,6 +61,10 @@ var DEBUG = true,
attrName = BWidget.getPropertyHTMLAttribute(node.getType(), propName);
propValue = newValue || node.getProperty(propName);
attrValue = propValue;
if (typeof attrName === "function") {
attrValue = attrName(propValue)["value"];
attrName = attrName(propValue)["name"];

This comment has been minimized.

@zhizhangchen

zhizhangchen Aug 3, 2012

Contributor

Would it be simpler to replace the above two lines with the following line:
attrName = attrName(propValue);

This comment has been minimized.

@maxyu

maxyu Aug 13, 2012

Contributor

updated

if(ret.result === false) {
$(this).val(node.getProperty(updated));
} else if(type === "Button" &&
value === "previous page") {
ADM.setProperty(node, "opentargetas", "page");

This comment has been minimized.

@zhizhangchen

zhizhangchen Aug 3, 2012

Contributor

Is this necessary?

This comment has been minimized.

@maxyu

maxyu Aug 13, 2012

Contributor

Yes. It elimated the needs to "disable" the property in serialize.

.attr('id', valueId)
.addClass('title')
.appendTo(value);
}

This comment has been minimized.

@zhizhangchen

zhizhangchen Aug 3, 2012

Contributor

Please simplify the above lines.

This comment has been minimized.

@maxyu

maxyu Aug 13, 2012

Contributor

done

},
opentargetas : {
type: "string",
displayName: "open target as",
options: ["default", "page", "dialog"],
defaultValue: "default",
options: ["page", "dialog"],

This comment has been minimized.

@zhizhangchen

zhizhangchen Aug 3, 2012

Contributor

Why do you remove "default"?

This comment has been minimized.

@grgustaf

grgustaf Aug 3, 2012

Contributor

Yeah, I think it's good the way it was, make it clear that you're preserving the page setting.

This comment has been minimized.

@maxyu

maxyu Aug 13, 2012

Contributor

Recovered.

@zhizhangchen

This comment has been minimized.

Contributor

zhizhangchen commented Aug 13, 2012

Please squash these fixup commits into previous ones.

@zhizhangchen

View changes

src/js/serialize.js Outdated
@@ -61,13 +61,29 @@ var DEBUG = true,
attrName = BWidget.getPropertyHTMLAttribute(node.getType(), propName);
propValue = newValue || node.getProperty(propName);
attrValue = propValue;
if (typeof attrName === "function") {
attrValue = attrName(propValue)["value"];

This comment has been minimized.

@zhizhangchen

zhizhangchen Aug 14, 2012

Contributor

This line is not necessary

@zhizhangchen

View changes

src/js/serialize.js Outdated
case "boolean":
break;
default:
throw "attrValue type can not handle";

This comment has been minimized.

@zhizhangchen

zhizhangchen Aug 14, 2012

Contributor

"handle" should be "handled"

@maxyu

This comment has been minimized.

Contributor

maxyu commented Aug 15, 2012

Updated.

@zhizhangchen zhizhangchen referenced this pull request Aug 15, 2012

Closed

Integration 20120815 #209

@grgustaf

This comment has been minimized.

Contributor

grgustaf commented Aug 17, 2012

Merged, thank you.

@grgustaf grgustaf closed this Aug 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment