Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Provide fine grained version detail for CMake find_package #100

Closed
wants to merge 1 commit into
base: tbb_2019
from

Conversation

Projects
None yet
2 participants
@hjmjohnson
Copy link

hjmjohnson commented Nov 10, 2018

Bug fixes to the interface often need to be accounted for when
finding a TBB package. Add the interface details as a
patch to the versioning.

ENH: Provide fine grained version detail for Cmake FindPackage
Bug fixes to the interface often need to be accounted for when
finding a TBB package.  Add the interface details as a
patch to the versioning.
@hjmjohnson

This comment has been minimized.

Copy link
Author

hjmjohnson commented Jan 19, 2019

@tbbdev Are there concerns about this PR?

@tbbdev

This comment has been minimized.

Copy link
Contributor

tbbdev commented Jan 21, 2019

Hi @hjmjohnson
Sorry for a long response and thank you for the proposal!
We'll implement it in one of the next TBB releases.

@hjmjohnson

This comment has been minimized.

Copy link
Author

hjmjohnson commented Jan 21, 2019

@tbbdev Will you close this PR once the upstream version has this incorporated?

@tbbdev

This comment has been minimized.

Copy link
Contributor

tbbdev commented Jan 22, 2019

Yes, we'll notify you here and close the PR.

@hjmjohnson

This comment has been minimized.

Copy link
Author

hjmjohnson commented Feb 22, 2019

Any progress on this?

@tbbdev

This comment has been minimized.

Copy link
Contributor

tbbdev commented Feb 25, 2019

It will be available in the next release.

@hjmjohnson

This comment has been minimized.

Copy link
Author

hjmjohnson commented Feb 27, 2019

Thanks. Closing assuming this has been completed.

@hjmjohnson hjmjohnson closed this Feb 27, 2019

@tbbdev

This comment has been minimized.

Copy link
Contributor

tbbdev commented Mar 1, 2019

Included to TBB 2019 Update 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.