New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various warnings when building with Visual C++ #70

Closed
wants to merge 2 commits into
base: tbb_2018
from

Conversation

Projects
None yet
3 participants
@e4lam

e4lam commented Jul 13, 2018

No description provided.

@nik-ponomarev

This comment has been minimized.

nik-ponomarev commented Jul 31, 2018

Could you, please, provide an MSVC version where these warnings were found?

@e4lam

This comment has been minimized.

e4lam commented Aug 1, 2018

Commit 0beb0e2 I believe originated with Visual Studio 2015 when compiling LTCG enabled on static builds. I'm not sure which service pack anymore but Visual Studio 2015 Update 3 was the last version we used before switching to Visual Studio 2017.

Commit 0ab186b was on Visual Studio 2017, version 15.Y.X. I'm not sure which 15.Y.X version anymore because of the numerous Visual Studio 2017 updates. It was probably on some latest 15.7.X update.

@nik-ponomarev

This comment has been minimized.

nik-ponomarev commented Oct 5, 2018

Warning fixes for 0beb0e2 is available in the latest TBB 2019 U1.
As for 0ab186b, we couldn't reproduce this problem and I think an issue is related to the usage of parallel_reduce and should be suppressed outside the tbb.

@hjmjohnson

This comment has been minimized.

hjmjohnson commented Nov 10, 2018

@e4lam Can this issue be closed now. Or the residual work be rebased on top of 2019_U2?

@e4lam

This comment has been minimized.

e4lam commented Nov 10, 2018

I think it can be closed for now. As I recall the problem showed up with some update of Visual C++ 2017 and building OpenVDB (openvdb.org) with /std:c++14 /permissive- . I'll reopen when I find some time again with exact reproducible steps.

@e4lam e4lam closed this Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment