Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base32 is broken #92

Closed
05nelsonm opened this issue Jan 31, 2023 · 2 comments · Fixed by #93
Closed

Base32 is broken #92

05nelsonm opened this issue Jan 31, 2023 · 2 comments · Fixed by #93
Labels
bug Something isn't working

Comments

@05nelsonm
Copy link
Owner

05nelsonm commented Jan 31, 2023 •
edited
Loading

When working on 05nelsonm/kmp-tor#274 updating to 1.2.0 results in test failures.

expected:<OBTD[DB6TEGTGVPNR2XDA5X5DEB4YXGLEHJHNGIIVBGF33]S2HNNRQ====> but was:<OBTD[FCGTEKTGXPVR23DA7YFDEB5IZGLEHJH5GIIVBKGL5]S2HNNRQ====>
Expected :OBTDDB6TEGTGVPNR2XDA5X5DEB4YXGLEHJHNGIIVBGF33S2HNNRQ====
Actual   :OBTDFCGTEKTGXPVR23DA7YFDEB5IZGLEHJH5GIIVBKGL5S2HNNRQ====

image

The correct value should be OBTDFCGTEKTGXPVR23DA7YFDEB5IZGLEHJH5GIIVBKGL5S2HNNRQ====

This is attributed to the change in the base32 bitwise operations.
@05nelsonm 05nelsonm added the bug Something isn't working label Jan 31, 2023
@05nelsonm 05nelsonm changed the title Base32 is broken Base32.Default is broken Jan 31, 2023
@05nelsonm
Copy link
Owner Author

Looks like only base32 default is affected.

@05nelsonm 05nelsonm mentioned this issue Jan 31, 2023
Merged
@05nelsonm 05nelsonm changed the title Base32.Default is broken Base32 is broken Jan 31, 2023
@05nelsonm
Copy link
Owner Author

PR #95 showed that Base32 Hex and Crockford implementations were also borked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix base32 encoding 05nelsonm/encoding
1 participant
@05nelsonm