random RegisterNode (Sharder)

[ssardana08]

Fixes

• fixed sharder registration delay in case miners were not up in network

Changes

• confirm transaction was blocking goroutine for server_chain.transaction.timeout
• if transaction.timeout was long, delay for retry of register sharder would be long.
• clients confirm txn timeout is now independent of transaction.timeout in global config

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

• Ensure system tests are passing. If not Run them manually to check for any regressions 📋
• Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
• Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

• blobber:
• gosdk:
• system_test:
• zboxcli:
• zwalletcli:
• Other: ...

[codecov-commenter]

Codecov Report

Merging #1528 (69d479a) into staging (9937272) will increase coverage by 0.01%.
The diff coverage is 25.00%.

@@             Coverage Diff             @@
##           staging    #1528      +/-   ##
===========================================
+ Coverage    29.39%   29.40%   +0.01%     
===========================================
  Files          361      361              
  Lines        59190    59202      +12     
===========================================
+ Hits         17397    17407      +10     
+ Misses       39865    39863       -2     
- Partials      1928     1932       +4     

Flag	Coverage Δ
Unit-Tests	29.40% <25.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
code/go/0chain.net/chaincore/chain/handler.go	8.12% <0.00%> (-0.02%)	⬇️
...0chain.net/chaincore/chain/protocol_view_change.go	0.00% <0.00%> (ø)
...n.net/chaincore/chain/protocol_view_change_main.go	0.00% <0.00%> (ø)
...ode/go/0chain.net/smartcontract/minersc/sharder.go	2.29% <0.00%> (-0.01%)	⬇️
...n.net/chaincore/httpclientutil/http_client_util.go	63.59% <100.00%> (+0.24%)	⬆️
...ain.net/smartcontract/storagesc/config_settigns.go	32.95% <0.00%> (ø)
...de/go/0chain.net/smartcontract/vestingsc/config.go	59.47% <0.00%> (+3.15%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

[service-0chain]

Manual system tests [success] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	NOT OVERRIDDEN
zboxcli	staging
zwalletcli	staging
0chain	fix/add_sharder
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	NOT OVERRIDDEN
zboxcli	staging
zwalletcli	staging
0chain	fix/add_sharder
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

[peterlimg]

lgtm

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	NOT OVERRIDDEN
zboxcli	staging
zwalletcli	staging
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

[service-0chain]

Manual system tests [success] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	NOT OVERRIDDEN
zboxcli	staging
zwalletcli	staging
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging