Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ZCN Service Fee #1975

Merged
merged 7 commits into from Jan 16, 2023
Merged

Added ZCN Service Fee #1975

merged 7 commits into from Jan 16, 2023

Conversation

din-mukhammed
Copy link
Contributor

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@din-mukhammed din-mukhammed linked an issue Jan 7, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Merging #1975 (77ffd4a) into staging (59839d6) will increase coverage by 0.01%.
The diff coverage is 54.05%.

@@             Coverage Diff             @@
##           staging    #1975      +/-   ##
===========================================
+ Coverage    26.00%   26.02%   +0.01%     
===========================================
  Files          370      370              
  Lines        61293    61321      +28     
===========================================
+ Hits         15938    15956      +18     
- Misses       43455    43457       +2     
- Partials      1900     1908       +8     
Flag Coverage 螖
Unit-Tests 26.02% <54.05%> (+0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
code/go/0chain.net/smartcontract/zcnsc/mint.go 45.80% <54.05%> (-0.81%) 猬囷笍
...ain.net/smartcontract/storagesc/config_settigns.go 54.76% <0.00%> (酶)
...de/go/0chain.net/smartcontract/vestingsc/config.go 58.42% <0.00%> (+3.15%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests to verify the service fee paying. So need to assert:

  • service fee is paid to all authorizers correctly
  • the mint tokens is correct

@peterlimg
Copy link
Member

@din-mukhammed please add the unit tests

@din-mukhammed
Copy link
Contributor Author

@peterlimg @dabasov added ut

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterlimg peterlimg merged commit 5188685 into staging Jan 16, 2023
@peterlimg peterlimg deleted the 1922_service_fee branch January 16, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZCN Service Fee
4 participants