New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ZCN Service Fee #1975
Added ZCN Service Fee #1975
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #1975 +/- ##
===========================================
+ Coverage 26.00% 26.02% +0.01%
===========================================
Files 370 370
Lines 61293 61321 +28
===========================================
+ Hits 15938 15956 +18
- Misses 43455 43457 +2
- Partials 1900 1908 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests to verify the service fee paying. So need to assert:
- service fee is paid to all authorizers correctly
- the mint tokens is correct
@din-mukhammed please add the unit tests |
@peterlimg @dabasov added ut |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
c2332bd
to
b7fcb64
Compare
Fixes
Changes
Need to be mentioned in CHANGELOG.md?
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):